Skip to content

Phase 12-f: every page in both themes - #73

Merged
LikelyCause merged 1 commit into
mainfrom
phase-12-pages
Nov 16, 2026
Merged

LikelyCause merged 1 commit into
mainfrom
phase-12-pages

Conversation

@LikelyCause

Copy link
Copy Markdown
Owner

Phase 12-f, the last Phase 12 item. I screenshotted every route in ui/src and every live gallery story at 1440 px and 900 px wide, in Day (light) and Night (dark). That's 194 targets and 776 screenshots, rendered in the CI Playwright image against the fixture server and fake data. The script was throwaway and is not committed. I looked at each target as a 2×2 composite (light and dark at both widths). The script also checked every target automatically for page-level horizontal overflow, low-contrast text and console errors.

Fixes

Page Theme / width What was wrong Fix
Every page with a neutral chip: Data list tags, Kind, Connections kind and projects, Notebooks "Stopped" / "Read-only", Jobs "Queued", the Project overview "Read-only" Night, and Day on the grey sidebar panel Gray light badges had no visible fill. In Night, Mantine's computed value (gray 9 darkened by 50%) is the card colour. In Day, #f0f0f0 disappears on the #f5f5f5 panel. theme/mantine.ts (a token mapping, not a token): --mantine-color-gray-light → surface-hover, -light-hover → border
Version (Endpoints badge), the Data list Kind badge, every outline badge Night Outline badges took Mantine's dark ramp shade 1, a near-white outline, so they were much louder than in Day theme/mantine.ts: gray-outline → border-strong; accent/good/warn/bad -outline → their own token. Day is unchanged because these are the values it already had.
Data list Both, 900 px and with the activity panel open The page-bar controls (Add a sample, Pull from…) wrapped onto two lines. "Add a sample" was clipped at the top of the bar. DataPage: that group is wrap="nowrap"
Tuning study (trials table) Both, 900 px State badges were cut to "C…", "Pr…", "F…" RunStatus keeps its width (min-width: max-content), so the table scrolls instead
Experiment (runs table) Both, 900 px Status cut to "Runni…" and Device to "G…" Same as the study table: RunStatus, plus the Device badge
Jobs / GPU queue Both, 900 px Status cut to "Queu…" JobStatus badge no longer shrinks
Run detail / evaluation (confusion grid) Day White text on diagonal cells from 55% share, about 2.6:1 on the mid-teal mix. In Night the light text on full-brightness blue was about 2.7:1. cellShade: the ink switches only past a 75% mix, and uses --inverse-ink (white in Day, black in Night). Both are about 4.5:1 or better.
Batch, not found Both The not-found card ran edge to edge with no page padding, unlike the Experiment version of the same state Wrapped in the shared Page frame, 560 px wide and centred, as Experiment does
Composition, Evaluation, Model, Models, Version, Endpoint, Connection, Connections: the whole page failing to load Both The error alert sat flush against the page bar and both edges ErrorAlert page puts it inside the page padding. Those eight pages use it.
Connections → new, with no kind chosen (and "only an owner can add") Both No page bar at all. The admin version of the same route had one. ConnectionPage shows a "New connection" bar for those states

I changed no token values. Only theme/mantine.ts maps Mantine's gray and outline variables to existing tokens. Nothing has been redesigned.

Left for the designer

  • The Data list's Kind and Assessment columns still end in an ellipsis at 900 px ("Dat…", "7 of 7 sett…"). The fixed-layout DataTable is meant to degrade that way; whether to drop or narrow columns there is a design call.
  • On the experiment workspace, the "Viewers can look but not change anything" notice is inset from the left edge of the content below it.
  • The Endpoint page repeats "Switch version…" and "Roll back" in both the page bar and the Serving card.
  • On the Explore toolbar, the "Target" label sits a few pixels lower than the "Data" and "Decisions" labels.

Checks

  • Typecheck clean. ESLint has no errors; the 6 warnings were already there. Prettier clean. Run in node:22 with the repo mounted.
  • vitest run: 95 files, 750 tests, all passed.
  • Gallery (gallery.spec.ts, both schemes, CI image): 32/32 passed with no snapshot changes. The changed badges and pages aren't in the snapshotted stories, or move less than the 1% threshold.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
@LikelyCause
LikelyCause merged commit 7d38bde into main Nov 16, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant