Repository navigation
Phase 12-f: every page in both themes - #73
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 12-f, the last Phase 12 item. I screenshotted every route in
ui/srcand every live gallery story at 1440 px and 900 px wide, in Day (light) and Night (dark). That's 194 targets and 776 screenshots, rendered in the CI Playwright image against the fixture server and fake data. The script was throwaway and is not committed. I looked at each target as a 2×2 composite (light and dark at both widths). The script also checked every target automatically for page-level horizontal overflow, low-contrast text and console errors.Fixes
lightbadges had no visible fill. In Night, Mantine's computed value (gray 9 darkened by 50%) is the card colour. In Day, #f0f0f0 disappears on the #f5f5f5 panel.theme/mantine.ts(a token mapping, not a token):--mantine-color-gray-light→surface-hover,-light-hover→borderoutlinebadgetheme/mantine.ts:gray-outline→border-strong; accent/good/warn/bad-outline→ their own token. Day is unchanged because these are the values it already had.DataPage: that group iswrap="nowrap"RunStatuskeeps its width (min-width: max-content), so the table scrolls insteadRunStatus, plus the Device badgeJobStatusbadge no longer shrinkscellShade: the ink switches only past a 75% mix, and uses--inverse-ink(white in Day, black in Night). Both are about 4.5:1 or better.Pageframe, 560 px wide and centred, as Experiment doesErrorAlert pageputs it inside the page padding. Those eight pages use it.ConnectionPageshows a "New connection" bar for those statesI changed no token values. Only
theme/mantine.tsmaps Mantine's gray and outline variables to existing tokens. Nothing has been redesigned.Left for the designer
Checks
node:22with the repo mounted.vitest run: 95 files, 750 tests, all passed.gallery.spec.ts, both schemes, CI image): 32/32 passed with no snapshot changes. The changed badges and pages aren't in the snapshotted stories, or move less than the 1% threshold.🤖 Generated with Claude Code
https://claude.ai/code/session_01LqNnEU86Q4fmrJnN2rXovS