Skip to content

Modernize repository - #209

Closed
Michiel-VandeVelde wants to merge 1 commit into
LinkedDataFragments:masterfrom
Michiel-VandeVelde:modernize-repository
Closed

Modernize repository#209
Michiel-VandeVelde wants to merge 1 commit into
LinkedDataFragments:masterfrom
Michiel-VandeVelde:modernize-repository

Conversation

@Michiel-VandeVelde

@Michiel-VandeVelde Michiel-VandeVelde commented Jul 27, 2026

Copy link
Copy Markdown

This PR begins modernizing the repository and brings the project closer to current development standards. as defined in #206 .

@jitsedesmet

Copy link
Copy Markdown

@rubensworks The commit message links to the PR on Miciel's fork, is that okay?

@rubensworks

Copy link
Copy Markdown
Member

Not really, as that approach will link to other unrelated issues/PRs in this repo.

@jitsedesmet

Copy link
Copy Markdown

@rubensworks yes, but not linking to it might make it harder to discover conversation head around a single commit/ PR?

@rubensworks

Copy link
Copy Markdown
Member

@rubensworks yes, but not linking to it might make it harder to discover conversation head around a single commit/ PR?

In that case, you could link it by including something like Michiel-VandeVelde/Server.js#7 in the commit message.
Then it won't clash with issues in this repo.

@jitsedesmet

Copy link
Copy Markdown

Oh, that's what you mean. Yes, maybe. For some reason it is still able to differentiate at this point, but let's look into it.

@jitsedesmet

Copy link
Copy Markdown

Cool. That should indeed work. @Michiel-VandeVelde can you update the short message of the commit on this branch?
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls#issues-and-pull-requests

@Michiel-VandeVelde

Copy link
Copy Markdown
Author

updated the commit!

@jitsedesmet

Copy link
Copy Markdown

Closed in favour of #212 such that all PR's and discussions are part of this repository. We will continue with making PRs to the feature branch. The PRs to the feature branch will be squashed such that the feature branch into master PR can be a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants