Repository navigation
Add nproc argument to Coherence.signif_test - #708
Merged
Merged
Conversation
If the caller is in a process pool, they may wish to disable or limit parallelization in pyleoclim.
CommonClimate
self-requested a review
October 17, 2026 10:31
CommonClimate
requested changes
Oct 17, 2026
CommonClimate
left a comment
CommonClimate
left a comment
Collaborator
There was a problem hiding this comment.
Hello Sam, thank you for adding this to the code. I'd be happy to merge once the CI test pass, but right now that is not the case. Can you investigate and fix?
Contributor
Author
|
Hi, thanks for reviewing! To me, it looks like the CI failures are unrelated to the changes in this PR. The same four tests are failing on this PR and on the current master, and it doesn't seem like the failing tests call the coherence code at all. |
CommonClimate
approved these changes
Oct 27, 2026
CommonClimate
left a comment
CommonClimate
left a comment
Collaborator
There was a problem hiding this comment.
I just approved a PR by @khider that should resolve the failing tests. I'm going to approve this so the system relaunches the CI suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the caller is in a process pool, they may wish to disable or limit parallelization in pyleoclim.