Repository navigation
Fix for Failed tests - #709
Merged
Merged
Fix for Failed tests #709
Conversation
CommonClimate
approved these changes
Oct 27, 2026
CommonClimate
left a comment
CommonClimate
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a fix for failed tests in the CI. As a reminder, DO NOT MERGE PULL REQUESTS IF THE TESTS ARE FAILING.
verify=Falseto skip verification.In the process of doing so, I realized that the if/else loop fails. So created a try/except (more appropriate of this problem) where if any part of the web scraping fails then it would default back to the static version. However, the static version returned a list and not a dictionary of key/synonyms making the verification in
Series.__init__fail. Generated the dictionary, including NOAA terms. This is very easy to do with Claude, so we should have that on a schedule.Fixed a few typos here and there.
When doing the tests, created a new conda environment and made sure everything worked with newer packages.