Repository navigation
Conversation
split_proxydb only added 'assim' and 'eval' tags, so when it is called once per seed (as in run_da_mc), a record drawn for assimilation by any earlier seed stayed assimilated, and the eval set overlapped the assim set. Also make clear_proxydb_tags reset tags to an empty set rather than a list, since other methods call tags.add(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TsdL1gpFWoD4LYexEPr6LD
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14.
split_proxydb()now removes theassimandevaltags of any previous split before tagging, so calling it once per seed (asrun_da_mc()does) gives an independent split each time. It also makesclear_proxydb_tags()resettagsto an empty set rather than a list, since other methods calltags.add().Tests.
test_resplit_replaces_previous_splitsplits 10 times with different seeds and checks that each split has the right number ofassimandevalrecords and that they don't overlap. It fails onmain. The full suite passes (218 tests).Note. The existing
test_same_seed_gives_same_splitresets the tags by hand between splits, which is no longer needed but still passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01TsdL1gpFWoD4LYexEPr6LD