Conversation
The chart rendered one Ingress whose every path pointed at the release's own Service on service.port, so nothing could route a path to a preview Service, to a named port, or to a controller annotation, which is how Argo Rollouts splits canary traffic on an ALB. Paths now take optional serviceName and servicePortName, and extraIngresses renders further Ingress objects for routes that cannot share one.
stigglor
force-pushed
the
feat/helm-multi-ingress
branch
from
September 10, 2026 22:00
3bf60cc to
ec44d41
Compare
Ziinc
reviewed
Sep 11, 2026
| # `nameSuffix` that keeps its name distinct from `<fullname>`. For routes that cannot share one | ||
| # Ingress, because they belong on different ingress classes or because an annotation applies per | ||
| # Ingress rather than per rule. `ingress.enabled` does not gate these. See README.md#ingress. | ||
| extraIngresses: [] |
Contributor
There was a problem hiding this comment.
we could make ingress an array instead?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart rendered one Ingress whose every path pointed at the release's own Service on service.port, so nothing could route a path to a preview Service, to a named port, or to a controller annotation, which is how Argo Rollouts splits canary traffic on an ALB. Paths now take optional serviceName and servicePortName, and extraIngresses renders further Ingress objects for routes that cannot share one.