Conversation
chasers
added this pull request to stack #3983
September 14, 2026 18:44
A page request drops the query's own timestamp range so it can page past it, and kept only a one-sided partition bound. The scan therefore ran to the end of the table: on BigQuery that is every partition the source has ever had. A page now moves by the width of the range in view, bounded below at 60 seconds. The query carries both a `TIMESTAMP_MICROS` bound and a partition-date bound on each side, for `:timestamp`, `:pseudo` and Postgres alike. The LQL range grows by that same window on every click, rather than only when the rows that came back happened to fall outside it, and an empty page shifts the cursor by the window instead of clearing it. A quiet stretch no longer stalls the button. `extend_timestamp_range/2` and `event_timestamp/2` are gone with that change. The buttons name the window they move by: "Load more (-10 minutes)" and "Load more (+10 minutes)". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YQ8Y8zCvSKUFNPvkwH2WS4
Dialyzer fails the typing check on `event_timestamp_datetime/1`. The only caller passes integer microseconds, so the `DateTime` and `NaiveDateTime` clauses can never match. Convert the integer directly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YBPF1knvgfghTSdxuYryGL
chasers
force-pushed
the
test/load-more-bigquery
branch
from
September 17, 2026 19:30
d5f280c to
39ef8c4
Compare
chasers
force-pushed
the
fix/load-more-page-window
branch
from
September 17, 2026 19:30
655b0d8 to
350e800
Compare
amokan
approved these changes
Sep 17, 2026
chasers
removed this pull request from stack #3983
September 17, 2026 21:09
chasers
added a commit
that referenced
this pull request
Sep 17, 2026
Squashes the nine-PR load more stack into one commit: #3976, #3977, #3978, #3979, #3980, #3981, #3982, #3984 and #3986. Merged as a unit so that main never carries the intermediate states that #3984 corrects. Pagination - Keep the "Load more" spinner up until the page query returns. - Bound a page request to the window in view and say so on the button. - Store one page window per search in `EventPagination`. The label, the query, the cursor shift and the range growth all read it. The window no longer doubles on each click. - Set the page window from a tail result too. A soft pause, play and pause used to leave the window nil and drop the next page request. - Write an implied timestamp range into the query on a page request. - Keep a one-sided `t:` bound when a page request makes the range explicit. - Clamp a "next" range extension at now. Each empty click used to push the range max another window into the future. - Cap the cursor of an empty "next" page at the request time. - Remove timestamp clauses that can never match. - Stop hiding the load more buttons on a short page. - Disable the other button while a page request runs. - Drop a page result or page error that no request waits for. - Clear the page spinner when a search fails to parse. - Log a page request that the LiveView drops. Scrolling - The LiveView drives every scroll. Every initial event page and every tail append pushes `scroll-to-bottom`. The server owns scroll intent. The hook owns viewport stability. Cleanup - Remove the unused sentinel row: the extra fetched row, `fetch_limit/0` and the `has_more?` field that nothing reads. - Build the chart range in the search timezone. An implied range is no longer UTC written as local time. - Remove the 750ms LiveView latency simulator in dev. Tests - Cover event pagination against a bigquery source and a postgres source. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 4/7 — "Load more" pagination fixes.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YBPF1knvgfghTSdxuYryGL