Repository navigation
Set the version to 0.17.0rc1 for the rc tag - #310
Merged
Merged
Conversation
The release workflow compares pyproject's version to the pushed tag
through packaging.version.Version, so an rc needs the rc version in
pyproject: Version("0.17.0") != Version("0.17.0rc1") and the test job
fails before any publish step runs.
RELEASING.md calls for these as two separate commits, one before each
tag, because the normalized forms differ. The bump in #308 was the
real-release form done early, correct for v0.17.0 and wrong for the rc.
v0.16.0-rc1 carried 0.16.0rc1 in all three places and v0.16.0 carried
0.16.0, which is the precedent.
Five files rather than three: uv.lock locks the local package's own
version, and the bundled AGENTS.md stamps it into its header. Both
regenerate.
Verified against the workflow's own comparison: the rc tag matches and
the real-release tag does not, which is what the second bump is for.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All required version references consistently match the normalized RC tag.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns package metadata with the upcoming v0.17.0-rc1 tag.
Changes:
- Updates all five package-version references to
0.17.0rc1. - Keeps runtime, lockfile, smoke test, and generated agent documentation synchronized.
| File | Description |
|---|---|
pyproject.toml |
Sets the release-candidate package version. |
src/openarmature/__init__.py |
Updates the runtime version constant. |
tests/test_smoke.py |
Updates the version assertion. |
uv.lock |
Synchronizes the editable package version. |
src/openarmature/AGENTS.md |
Updates the generated version header. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step one of two version bumps. This must merge before
v0.17.0-rc1is pushed, or the tag fails.Why
release.ymlcompares pyproject's version to the pushed tag throughpackaging.version.Version:Version("0.17.0") != Version("0.17.0rc1"), so pushing the rc tag against the current main fails the test job before any publish step runs.RELEASING.md:64-67calls for two separate commits, one before each tag, "because the normalized forms differ". The bump in #308 was the real-release form done early: correct forv0.17.0, wrong for the rc.Precedent
v0.16.0-rc1v0.16.0pyprojectversion0.16.0rc10.16.0__version__0.16.0rc10.16.0test_smokeassertion0.16.0rc10.16.0All three move together, which is what
RELEASING.md:66-67requires.Five files, not three
RELEASING.mdnames pyproject,__version__and the smoke-test assertion. Two more carry it and regenerate:uv.locklocks the local package's own versionsrc/openarmature/AGENTS.mdstampsversion 0.17.0rc1 (spec v0.118.2)into its headerBoth diffs are one line each.
Verified against the workflow's own comparison
The second line is correct and expected. The real-release tag needs the second bump, which is a separate PR after the rc is verified.
Artifacts build and carry the rc version:
Metadata-Version: 2.4confirms thehatchling<1.30pin still holds.Note on the CHANGELOG date
The 0.17.0 heading says
2026-10-04, correct as of this PR being opened. It documents the release rather than the rc, so it does not move for the rc tag — but if the real-release tag slips to another day it needs refreshing beforev0.17.0.After this
v0.17.0-rc1to TestPyPI only. No PyPI, no GitHub Release. Then verify the artifact installs from the index and the examples run against it, then a second PR returning the version to0.17.0beforev0.17.0.