Repository navigation
Move the roadmap's informal items to issues, and link solprop - #39
Merged
Merged
Conversation
The roadmap now lists only accepted and draft OEPs. Its items are issues #10 to #31, the papers wanted have their own page, and the pages that pointed at the roadmap point at those. OEPs 7 and 8 name their tracking issues. The propagation page gains a section on solprop as the worked example of its interface, with links to its manual and SEPs, and the overview names it. The gallery helpers now describe solprop's old values as former, not current. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third of three PRs bringing optmat up to solprop's standards, and the one that does most of the solprop cross-referencing. It's stacked on #38, so retarget it to
mainonce #9 and #38 have merged.What changed
docs/roadmap.md: cut from 442 lines to 73: the accepted and draft OEP lists, plus a note saying where everything went, with a permalink to the old page.docs/wanted.md: new, holding Papers and data we are looking for word for word apart from its intro. It's about 150 lines of citations for outside readers, so it stays one page with one umbrella issue (Papers and data we are looking for #31) rather than about 60 small issues. This is a judgement call and easy to reverse.docs/propagation.md: a new solprop section names it as the worked example of this interface, and links its manual and SEPs 3, 6, 11 and 17.docs/introduction/overview.md: now names solprop, which it didn't before.docs/gallery/_helpers.py: solprop's old values are now described as former, not current.Every roadmap item
docs/propagation.md, "never depends" toAGENTS.md(#9)docs/silica.mddocs/wanted.md, #31Issues found along the way, not from the roadmap: #15 (Raman collision partners, for LupoLab/solprop#285), #32 (LupoLab/solprop#166), #33 (CI cost), #34 (retire
tools/solprop_*.py), #37 (sdist built under.claude/).Left alone on purpose
REGISTER.md,CHANGELOG.mdhistory and Final OEPs: they are records.data/gas/*.toml: a few say "requested (roadmap)", but editing them would change catalogue entries and possibly digests. The roadmap's note covers them.against-solpropanchors, so inbound links keep working.intersphinxentry: there are too few links to justify an offline inventory.Verified
poe checkon this tree: 21539 passed, 1 skipped, 100.00% coverage, docs built with warnings as errors. It takes the full gate rather than the documentation-only checks because_helpers.pyis a gallery file.wanted.htmlwon't resolve until this merges, and Ionisation rates: the reference data and calculations still wanted #12, Raman line data: N2O's rotations, modern H2 and D2 level energies, Q-branch widths #13, Structure coefficients of CH4, SF6 and N2O, and the remaining cations' polarizabilities #16 and Papers and data we are looking for #31 link to it.docs/roadmap.mdis existing text that was kept.Not checked: issue text transcribed from the roadmap wasn't re-checked against the code or papers, and each of those issues says so.
🤖 Generated with Claude Code