Repository navigation
Conversation
A broadcast input no longer becomes a whole volume to be digested, and a byte-swapped one no longer takes a copy. Every digest is as it was, which the record tests hold. Closes #493. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPtq9Gp7VCh5QmcDdzQ
The same bits as the rational sum, which a test holds, without a Fraction per node. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPtq9Gp7VCh5QmcDdzQ
The passes over a beam's elements ran on one thread, and the admittance ran twice. The sum that scales the field stays one sum in one order, so every bit of the launch is as it was, which a test holds across thread counts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPtq9Gp7VCh5QmcDdzQ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPtq9Gp7VCh5QmcDdzQ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPtq9Gp7VCh5QmcDdzQ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPtq9Gp7VCh5QmcDdzQ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPtq9Gp7VCh5QmcDdzQ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPtq9Gp7VCh5QmcDdzQ
Contributor
Author
|
Folded into #520, at the maintainer's request for far fewer PRs: each one and each push costs a full CI run. This description keeps its tables and per-section verification, and the code is in that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A draft, stacked on #517, then #516, which should land first. No number changes: every bit of a launch and every digest is as it was, and tests hold both.
What changed
math.fsum, the same bits as the rational sum, without a PythonFractionper node.Why
At 768 × 768 × 600, a free-space launch took about three minutes to build, longer than the steps of a short point.
Simulation.from_freetranslaterunnerA shared machine, so read these as sizes rather than exact ratios.
How it was verified
Local, on the stack:
tests/test_pulses.py,test_cartesian_precision.py,tests/output/test_field_retention.py,test_monitor.py,test_process.pyandtest_structure_figures.py, 724 passed before the last merge from #517, and rerun after it;ruffclean.Tests hold the launch's bits across thread counts (
tests/test_pulses.py), the residual against the rational sum (tests/test_cartesian_precision.py) and a broadcast input's digest and peak memory (tests/output/test_field_retention.py).What's left of the plan for this
SimulationRunnerwould pay is unmeasured where it could #298 and A plane-reducing scan needs a full Output implementation #499, a scan worker keeping a runner and a reducing scan as a callable, aren't in this PR. A lockstep batch observes every member's field at every plane, even when the scan keeps none #299 only matters if measured above its 5 %.kerr_beam_384#347 stays open: this takes the launch's part of a run's fixed cost, and doesn't profile the rest.Not run
No GPU run, since this changes host Python only. macOS, Windows, the slow lane and coverage: left to CI.
Links
Closes #493, by hand once the stack lands, since
Closesonly acts on a PR based onmain. Relates to #347. Depends on #517 and #516.Suggested labels:
performance.🤖 Generated with Claude Code
https://claude.ai/code/session_01XGENPtq9Gp7VCh5QmcDdzQ