Repository navigation
Say beta, and stop claiming what Luna also has - #526
Merged
Merged
Conversation
The classifier moves from Alpha to Beta. The Luna guide's list of capabilities beyond Luna no longer names gas mixtures or Slurm scans, since Luna has both, and the README's timing for its headline example is brought up to date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small corrections.
pyproject.tomlmoves from3 - Alphato4 - Beta, with a release-note fragment. The comment that interfaces may change between 0.x releases stays.SlurmExecinsrc/Scans.jl,examples/low_level_interface/mixtures). The Slurm line goes, and the mixtures line now reads "Steady-flow gas fills". I grepped Luna'sCapillary.jlandInterface.jlfor flow and found nothing, but did not check the rest of Luna, so steady-flow fills staying on the list is read, not proven.What I ran:
docs/examples/processes/plot_00_vuv_dispersive_wave.pyfrom the v0.1.0 tag with the released 0.1.0 wheels, on an Apple M5 Max with 4 threads at low priority: 8.5 s for build and solve together, with 301 saved planes. The README's own snippet saves the default 201 planes and was not timed separately.mainwas not timed.Not run locally: tests, the docs build and
poe changelog-check. CI gates those.🤖 Generated with Claude Code