Repository navigation
feat: a review skill proves how a change hurts a person - #19
Merged
Merged
Conversation
The review skill is the method a reviewer follows inside a review flow: run the build and the tests first, hunt only what no existing test catches, prove each harm by running a probe in a throwaway worktree, and write each finding with its evidence, smallest fix and pinning test. The review ends with the claims checked, what was declined and a verdict, and nothing is posted without the person's yes. The routing table sends "review a diff" to it, inside the superpowers and gstack review flows. The eval fixture seeds a leaked token, a false success message and a raw-versus-cleaned path seam. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A new
reviewskill: the review method itself, for a pull request, a branch or a diff of any size. The reviewer proves how a change hurts a real person and hands over the fix and the test that pins it.file:line, the concrete situation, evidence ("confirmed by running" with input → output, or "from reading"), the smallest fix, and the test that pins it. Summary first, "Declined to judge" and a verdict last.The routing table now sends "Review a diff, a branch or a PR" to builder
review, used inside superpowersrequesting-code-reviewor gstack/review. The README, AGENTS.md and CONTRIBUTING.md count nine skills; plugin.json gains thecode-reviewkeyword.Type of change
feat— new featureChecklist
bash scripts/validate.shpasses locally (with the scrub). On macOS's bash 3.2 the script itself fails to parse (a heredoc inside$(...)at line 103, also on main); it passed with that heredoc moved out in a temporary copy. CI runs a newer bash.skills/review/SKILL.mdhas valid frontmatter (name+description)--plugin-dirNotes for reviewer
Eval:
tests/evals/review/is a tiny notes app whose change breaks all three of its own description's claims while its tests pass: a token logged into a file the README says to attach to bug reports, a "your notes are safe" message counted over failed uploads, and an ignore rule compared raw against cleaned paths. Without the skill (4 runs) the agent finds the bugs but shows none of the sixexpect.mdbehaviours. With the skill (3 iterations), the final run shows all six. In 3 of 8 runs the headless permission check blocked the probe commands in both arms; the skill then marks findings "from reading" and says what it could not run. In one baseline run the agent applied the patch to the checkout itself, which the skill's rule prevents.🤖 Generated with Claude Code