Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/benchmark-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,8 @@ jobs:
rows = parse_rows(logs_dir + "/" + fw + ".log", fw)
deltas = parse_deltas(logs_dir + "/" + fw + ".compare.md")
head = (table(rows, deltas) + composite(fw) if rows else "No results captured") + spec(fw, limit)
if fw in failed:
head = "**Run failed; valid partial results follow.**\n\n" + head
if tails:
head += "\n\n" + details("Full log", tail(logs_dir + "/" + fw + log_suffix, 200))
return head
Expand Down
33 changes: 33 additions & 0 deletions .github/workflows/benchmark-tools.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Benchmark tool checks

on:
pull_request:
paths:
- .github/workflows/benchmark-tools.yml
- .github/workflows/benchmark-pr.yml
- .github/workflows/pr-commands.yml
- frameworks/_shared/authsvc/**
- docker/h2load.Dockerfile
- scripts/benchmark.sh
- scripts/benchmark-lite.sh
- scripts/composite_delta.py
- scripts/lib/common.sh
- scripts/lib/tools/h2load*
- scripts/tests/**

jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check shell syntax
run: bash -n scripts/benchmark.sh scripts/benchmark-lite.sh scripts/lib/common.sh scripts/lib/tools/h2load.sh scripts/lib/tools/h2load-h3.sh
- name: Build auth sidecar
run: docker build -t httparena-authsvc:test frameworks/_shared/authsvc
- name: Build HTTP/2 load generator
run: docker build -t httparena-h2load:test -f docker/h2load.Dockerfile docker
- name: Test parsers, exit codes and images
env:
HTTPARENA_TEST_AUTHSVC_IMAGE: httparena-authsvc:test
HTTPARENA_TEST_H2LOAD_IMAGE: httparena-h2load:test
run: python3 -B -m unittest discover -s scripts/tests -p 'test_*.py' -v
34 changes: 18 additions & 16 deletions docker/h2load.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
# h2load — HTTP/2 load generator from the nghttp2 project.
#
# Uses Ubuntu + apt-installed `nghttp2-client` (glibc build) instead of
# alpine's musl build. The alpine h2load suffers ~20-40% throughput loss
# on high-QPS workloads because of musl's per-call malloc overhead and
# thread primitives — unacceptable for a benchmark load generator.
#
# Self-contained: installs nghttp2 directly from the Ubuntu archive during
# the build; no source checkout, no local file dependencies.

FROM ubuntu:24.04
# nghttp2 1.69 includes the duration-mode connection shutdown fix in PR #2613.
# Keep glibc and jemalloc for the high-throughput load generator.

FROM ubuntu:24.04 AS builder
ENV DEBIAN_FRONTEND=noninteractive
RUN apt-get update \
&& apt-get install -y --no-install-recommends \
nghttp2-client ca-certificates \
&& apt-get clean \
RUN apt-get update && apt-get install -y --no-install-recommends \
ca-certificates git cmake ninja-build g++ pkg-config \
libssl-dev libev-dev libjemalloc-dev zlib1g-dev \
&& rm -rf /var/lib/apt/lists/*

WORKDIR /src
RUN git clone --depth 1 --branch v1.69.0 --recurse-submodules --shallow-submodules https://github.com/nghttp2/nghttp2.git \
&& cmake -S nghttp2 -B build -G Ninja \
-DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=20 \
-DENABLE_APP=ON -DENABLE_EXAMPLES=OFF -DENABLE_HPACK_TOOLS=OFF \
-DBUILD_SHARED_LIBS=OFF -DBUILD_STATIC_LIBS=ON \
&& cmake --build build --target h2load -j 4
FROM ubuntu:24.04
RUN apt-get update && apt-get install -y --no-install-recommends \
ca-certificates libev4t64 libjemalloc2 libssl3t64 zlib1g \
&& rm -rf /var/lib/apt/lists/*
COPY --from=builder /src/build/src/h2load /usr/local/bin/h2load
ENTRYPOINT ["h2load"]
2 changes: 1 addition & 1 deletion frameworks/tako-gateway/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# tako-gateway

The gateway profiles for [Tako](https://github.com/rust-dd/tako) 2.4.2, reported as `tako`.
The gateway profiles for [Tako](https://github.com/rust-dd/tako) 2.7.1, reported as `tako`.
The server is built from [`frameworks/tako`](../tako); this directory only holds
the compose files and the edge configuration.

Expand Down
106 changes: 26 additions & 80 deletions frameworks/tako-grpc/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frameworks/tako-grpc/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ edition = "2024"

[dependencies]
prost = "0.14"
tako-rs = { version = "2.4.1", features = ["grpc", "http2", "tls"] }
tako-rs = { version = "2.7.1", features = ["grpc", "http2", "tls"] }
tokio = { version = "1", features = ["macros", "net", "rt-multi-thread"] }

[profile.release]
Expand Down
Loading