Skip to content

PR commands: no false fails on branches behind main - #1810

Merged
MDA2AV merged 1 commit into
mainfrom
ci-skew-false-fails
Nov 16, 2026
Merged

MDA2AV merged 1 commit into
mainfrom
ci-skew-false-fails

Conversation

@MDA2AV

@MDA2AV MDA2AV commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Two workflow bugs marked good runs as failed on PRs whose branch is behind main. #1758 hit both.

  1. False "main has diverged" on --save. The dry run fetched main with --depth=1 into a full-history checkout. That cuts main's tip off from its parents, so git refuses with refusing to merge unrelated histories for any branch behind main. Every passing pre-check I sampled was "Already up to date", so it never actually tested for conflicts (fib v1.8.0, fib-tuned compression, go-stdlib HTTP/2, add quic-go #1758 merges main cleanly). Fixed by fetching without --depth, in 5 places. The lines match the same change in fix: update Tako to 2.7.1 and validate benchmark results #1762, so either PR merges cleanly after the other.
  2. Every entry marked ❌ after benchmarking fine. benchmark-pr.yml runs from main but uses the PR's scripts, and since Compliance: a /spec route for the protocol-compliance suites, aspnet-minimal first #1777 it calls scripts/spec.sh after every full benchmark. A branch cut before Compliance: a /spec route for the protocol-compliance suites, aspnet-minimal first #1777 doesn't have that script, so all six fib v1.8.0, fib-tuned compression, go-stdlib HTTP/2, add quic-go #1758 entries failed on ./scripts/spec.sh: No such file or directory (run 43751778310). The suites are now skipped with a notice when the script is missing. A spec-only run on such a branch still fails.

Tested:

  • Reproduced the refusal on fib v1.8.0, fib-tuned compression, go-stdlib HTTP/2, add quic-go #1758's head, and the clean merge once --depth is dropped.
  • Ran the patched "Run benchmarks" step against stub scripts. Old branch: no failures, plus the notice. Spec passes: no failures. Spec fails: entries still marked failed. Spec-only run on an old branch: still fails.

Workflows run from main, so this takes effect once merged.

🤖 Generated with Claude Code

Two workflow bugs marked good runs as failed on PRs whose branch is behind main:

- The --save dry run (and the merge in benchmark-pr.yml) fetched main with
  --depth=1 into a full-history checkout. That writes main's tip into
  .git/shallow, the merge-base disappears, and git refuses with "refusing to
  merge unrelated histories" - reported as "main has diverged". Every
  passing pre-check was "Already up to date"; it never tested for conflicts.
  Fetch without --depth.
- benchmark-pr.yml runs from main but with the PR's scripts, and since #1777
  it calls scripts/spec.sh after every full benchmark. A branch cut before
  #1777 has no spec.sh, so every entry was marked failed after benchmarking
  fine (#1758: Failed: 6). Skip the suites with a notice when the script is
  missing; a /spec run still fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant