Skip to content

nghttp2, nghttp3, http3: a synchronous buffered handler that answers null takes down the whole connection, and on h3 an awaited one is never answered #616

Closed

Description

@MDA2AV

The sibling stacks of #592. In each, a null answer throws NullReferenceException where the response is first read, before anything is submitted, so a 500 could still go out on its stream. At main:

Fix. As #603 does for ioxide.http2: a null answer gets a 500 on its own stream and is reported like a handler that throws, while anything else thrown once a response has been handed over still ends the connection. The h3 stacks need it on the awaited path as well. #601 adds a call after Submit in DispatchReadyAsync and CompleteBufferedAsync, so it touches the same lines.

nghttp2's synchronous case was reproduced by #592's verification run; ioxide.http3's synchronous and awaited cases, with a body-reader handler, were confirmed on a recording transport by #587's implementer. The rest is from reading at main 19aec5c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingseverity:lowPolish / minor win

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions