You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
nghttp2, nghttp3, http3: a synchronous buffered handler that answers null takes down the whole connection, and on h3 an awaited one is never answered #616
The sibling stacks of #592. In each, a null answer throws NullReferenceException where the response is first read, before anything is submitted, so a 500 could still go out on its stream. At main:
ioxide.nghttp3. Synchronous: DispatchBufferedSync (Nghttp3Connection.RunBuffered.cs:70-82) and DispatchBufferedAsync's completed fast path (:113-118) call QueueResponse with no catch, which throws in PackHeaders (Nghttp3Connection.Egress.cs:10-17). The throw leaves RunCoreAsync, a try/finally (Nghttp3Connection.cs:160-202), so RunAsync faults and every other request on the connection goes unanswered, with no CONNECTION_CLOSE, since none is sent without a code (:115-126). Awaited: CompleteBufferedAsync calls QueueResponse outside its try (RunBuffered.cs:129-153); its fire-and-forget task faults and the stream is never answered.
ioxide.http3.Submit reads resp.HeadIsValid first (Http3Connection.cs:793-797). Synchronous: DispatchReady (:674-686) and DispatchReadyAsync's fast path (:721-727) have no catch, so RunAsync faults with no answer and no CONNECTION_CLOSE, since only a fatal teardown closes the connection (:235-244). Awaited: CompleteBufferedAsync calls Submit outside its try (:736-757); the exception is lost in the fire-and-forget task and the stream is never answered.
Fix. As #603 does for ioxide.http2: a null answer gets a 500 on its own stream and is reported like a handler that throws, while anything else thrown once a response has been handed over still ends the connection. The h3 stacks need it on the awaited path as well. #601 adds a call after Submit in DispatchReadyAsync and CompleteBufferedAsync, so it touches the same lines.
nghttp2's synchronous case was reproduced by #592's verification run; ioxide.http3's synchronous and awaited cases, with a body-reader handler, were confirmed on a recording transport by #587's implementer. The rest is from reading at main 19aec5c.
Activity
nghttp2, nghttp3, http3: a buffered handler that answers null gets a …