Repository navigation
defaults: a server runs one proactor unless told otherwise, not twelve whatever the machine (#40) - #55
Merged
Conversation
…e whatever the machine (#40) Each proactor has its own ring and receive buffers, recvSlots x recvBufferSize = 128 MiB with the defaults, and even a few connections come to touch all of them, so twelve came to about 1.5 GiB, and to more proactors than CPUs on a small machine. A server that wants more sets proactorCount; every playground sample already does, and the Ktor engine passes its own count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40.
ServerConfig.proactorCountdefaulted to 12 whatever the machine. Each proactor has its own ring and receive buffers,recvSlotsxrecvBufferSize= 128 MiB with the defaults, and even a few connections come to touch all of them, so the default came to about 1.5 GiB, and to more proactors than CPUs on a small machine.It now defaults to 1, and the doc says how to ask for more. This follows MDA2AV/ioxide#560, which makes the same change to
ReactorCount.Nothing in the repo relies on the old default: every playground sample sets
proactorCount, and the Ktor engine passes its own count. A host that never set it now runs one proactor instead of twelve, which is the behaviour change to know. The receive pool sizes stay as they are.Tests.