LNHU-265: Copy and style tweaks to v1 search widget form - #214
Merged
Conversation
matt-bernhardt
approved these changes
Aug 26, 2026
matt-bernhardt
left a comment
Member
There was a problem hiding this comment.
This looks fine to me, so ![]()
(My assumption about this is that the CSS stylesheet for this plugin is still in v1 mode, which is why we're not relying on the color variables that were defined for the new homepage?)
Author
Yep, exactly. One of the many tendrils we'd need to investigate as we migrate from v1 to v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer
Now that we've switched our homepage's search form copy, we want to mirror that on the v1 version. This work:
I noticed the v2 widget search button does not have a disabled state to match the v1's behavior, and added that to a future ticket.
https://mitlibraries.atlassian.net/browse/LHNU-265
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES | NO dependencies are updated
Code Reviewer
(not just this pull request message)