Skip to content

LNHU-265: Copy and style tweaks to v1 search widget form - #214

Merged
djanelle-mit merged 2 commits into
masterfrom
lnhu-265
Aug 26, 2026
Merged

LNHU-265: Copy and style tweaks to v1 search widget form#214
djanelle-mit merged 2 commits into
masterfrom
lnhu-265

Conversation

@djanelle-mit

@djanelle-mit djanelle-mit commented Aug 26, 2026

Copy link
Copy Markdown

Developer

Now that we've switched our homepage's search form copy, we want to mirror that on the v1 version. This work:

  • Updates the label and placeholder strings to match SML and homepage
  • Updates the search button to Red when enabled to match SML and homepage search buttons.

I noticed the v2 widget search button does not have a disabled state to match the v1's behavior, and added that to a future ticket.

https://mitlibraries.atlassian.net/browse/LHNU-265

Stylesheets

  • Any theme or plugin whose stylesheets have changed has had its version
    string incremented.

Secrets

  • All new secrets have been added to Pantheon tiers
  • Relevant secrets have been updated in Github Actions
  • All new secrets documented in README

Documentation

  • Project documentation has been updated
  • No documentation changes are needed

Accessibility

  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)

Stakeholder approval

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies

YES | NO dependencies are updated

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • The changes have been verified
  • The documentation has been updated or is unnecessary
  • New dependencies are appropriate or there were no changes

@matt-bernhardt matt-bernhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, so :shipit:

(My assumption about this is that the CSS stylesheet for this plugin is still in v1 mode, which is why we're not relying on the color variables that were defined for the new homepage?)

@djanelle-mit

Copy link
Copy Markdown
Author

(My assumption about this is that the CSS stylesheet for this plugin is still in v1 mode, which is why we're not relying on the color variables that were defined for the new homepage?)

Yep, exactly. One of the many tendrils we'd need to investigate as we migrate from v1 to v2.

@djanelle-mit
djanelle-mit merged commit 2b4e038 into master Aug 26, 2026
3 checks passed
@djanelle-mit
djanelle-mit deleted the lnhu-265 branch August 26, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants