fix(openai): finalize streams even when usage chunks are omitted - #67
Open
imMamdouhaboammar wants to merge 5 commits into
Open
fix(openai): finalize streams even when usage chunks are omitted#67imMamdouhaboammar wants to merge 5 commits into
imMamdouhaboammar wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make streamed OpenAI-compatible responses produce an explicit final snapshot even when the endpoint does not return the optional usage chunk requested by
stream_options.include_usage.Root cause
StreamAccumulatorusedusage !== undefinedas the only final-state signal. OpenAI returns usage on a final empty chunk wheninclude_usageis honored, but compatible endpoints can omit usage metadata. In that case every yielded provider snapshot remained markedstreaming: true, tying message completion to optional accounting data.Changes
finish()so iterator exhaustion can mark the accumulator complete without inventing usageOpenAIModelProvider.stream()emit one final non-streaming snapshot after iterator exhaustion only when no usage chunk already finalized the streamThis keeps token accounting when available while making the streaming contract independent of an optional provider feature.