fix(approvals): cancel pending approval prompts when agent aborts - #71
Open
imMamdouhaboammar wants to merge 9 commits into
Open
fix(approvals): cancel pending approval prompts when agent aborts#71imMamdouhaboammar wants to merge 9 commits into
imMamdouhaboammar wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagate the active agent
AbortSignalinto tool-approval middleware and makeApprovalManagercancel displayed or queued requests when a run is aborted.Root cause
Approval middleware previously received only the tool call and agent context. If the user aborted while an interactive approval was pending, the agent stream could stop but
ApprovalManager.askUser()remained unresolved and its current request stayed published to the TUI. The approval prompt therefore continued to occupy the interface until the user answered a request belonging to an already-cancelled run.Changes
AbortSignalinbeforeToolUsemiddleware paramsAgent._act()through_beforeToolUse()askUserApprovalManager.askUser()signal-awareAbortErrornullwhen it becomes emptyRegression coverage
This complements tool-level cancellation by ensuring the interactive approval UI is cancelled at the same session boundary.