fix(openai): do not force temperature in compatible requests - #73
Open
imMamdouhaboammar wants to merge 2 commits into
Open
fix(openai): do not force temperature in compatible requests#73imMamdouhaboammar wants to merge 2 commits into
imMamdouhaboammar wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop
OpenAIModelProviderfrom injectingtemperature: 0into every OpenAI-compatible Chat Completions request.Root cause
The adapter is used for both OpenAI and third-party OpenAI-compatible endpoints, but
_baseChatCompletionParams()imposed a sampling policy even when the caller supplied no sampling options. That creates avoidable compatibility failures for models/endpoints with different parameter support and prevents the provider from using each model's API default.The Chat Completions API defines
temperatureas optional. Adapter defaults should therefore omit it unless a caller explicitly requests a value.Changes
temperature: 0field from base request paramsoptions.temperatureThis keeps the provider generic and moves sampling policy to the caller that knows the selected model's contract.