Repository navigation
fix: separate volume dialog, button and track corner radius controls - #992
Merged
Mahmud0808 merged 2 commits intoNov 3, 2026
Merged
Mahmud0808 merged 2 commits into
Mahmud0808 merged 2 commits into
Conversation
The settings screen now exposes separate dialog, slider track, and selected ringer button radius controls. The existing preference controls dialog backgrounds, while two new preferences control the track and selected button independently and default to zero. Each control retains the −50 to +50 dp range and reset button on Android 16 and later, and changes trigger the SystemUI restart prompt. Refs Mahmud0808#987
Contributor
Author
|
Many thanks @Mahmud0808 for taking this one. Separate radius controls for the volume dialog, slider tracks and selected ringer button should make those shapes much easier to tune independently. |
Owner
|
Thanks for the contribution! Really appreciate your effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changing the volume corner radius also changes the slider tracks and selected ringer button, so users cannot adjust these shapes independently. Refs #987.
The same preference supplied both the volume slider style and the dimension offsets for the dialog backgrounds and selected ringer button.
What this changes
The settings screen now exposes separate dialog, slider track, and selected ringer button radius controls. The existing preference controls dialog backgrounds, while two new preferences control the track and selected button independently and default to zero. Each control retains the −50 to +50 dp range and reset button on Android 16 and later, and changes trigger the SystemUI restart prompt.
How it was tested
The command
gradle --no-daemon :app:testClassesfailed because the app project has no testClasses task, so no tests ran.Closes #987