Skip to content

fix: improve scanner actions and deletion - #74

Merged
Majkey25 merged 8 commits into
mainfrom
fix/delete-both/04-10-2026
Oct 7, 2026
Merged

Majkey25 merged 8 commits into
mainfrom
fix/delete-both/04-10-2026

Conversation

@Majkey25

@Majkey25 Majkey25 commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Changes

  • Shorter Delete both label, with translations.
  • Recognize supported values across adjacent OCR words with matched-word bounds.
  • Preserve valid payment-card detection beside currency labels.
  • Handle asynchronous speech errors without reporting canceled/stale playback.
  • Prepare 1.8.5 and document the separate editions. No monetization code added.

Verification

  • Signed local release gate passed: 612 JVM tests, lint, APK/AAB policy and provenance checks.
  • GitHub CI run 37580345385 passed for a9a3379.
  • Huawei Android 10: scan/import, OCR export, search, QR, Safe Share, signature/redaction, manual/smart cleanup, PDF rename/size, PNG conversion, share chooser cancellation, and Delete both.
  • Actual saved PDF/image files pulled and inspected. Cleanup removed the synthetic spot without removing text; signature and redactions remain in saved output.
  • Text-to-speech initialized and reached AudioTrack playback. Audible quality was not assessed. No real purchase or document delivery performed.
  • Public app source is unchanged since the prior tested candidate; this branch also merges the existing upstream privacy/terms disclosure.

@Majkey25 Majkey25 changed the title fix: shorten combined deletion label fix: improve scanner actions and deletion Oct 4, 2026
@Majkey25
Majkey25 marked this pull request as draft October 4, 2026 09:09
Currency matching must not suppress a validated card number. Keep card protection ahead of money matching and cover both whole and split card values.
@Majkey25
Majkey25 marked this pull request as ready for review October 7, 2026 06:31
@Majkey25
Majkey25 merged commit 0794f2e into main Oct 7, 2026
1 check passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T06:32:07.999872Z a9a3379 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-07T06:33:15.370997Z a9a3379 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant