Skip to content

feat: add Appearance settings and Save both - #77

Merged
Majkey25 merged 5 commits into
mainfrom
fix/save-both/07-10-2026
Oct 7, 2026
Merged

Majkey25 merged 5 commits into
mainfrom
fix/save-both/07-10-2026

Conversation

@Majkey25

@Majkey25 Majkey25 commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Changes

  • Rename the combined manual-save button to Save both, with translations.
  • Add Settings → Appearance: independent light/dark presets, System/Light/Dark mode, Material You on Android12+, custom accent/background colors with previews, fonts, text size, corner rounding, pure-black dark mode, and reset.
  • Persist appearance separately from scan rendering and retain existing defaults until changed.
  • Keep custom text/buttons readable on actual dialog surfaces, synchronize late committed settings, and restore sliders after failed saves.
  • Defer PDF preset-list initialization to prevent a cold settings crash.
  • Prepare1.9.0/code46. Public source remains fully unlocked with no Ads or Billing.

Verification

  • Palette, invalid-input, persistence, and private access-mode preservation checks passed.
  • Independent Codex review found three issues; all addressed. Claude review was unavailable due to weekly limit.
  • Final signed public gate passed:617 JVM tests,0 failures/skips, lint0 errors21 warnings1 hint, APK/AAB package/certificate/provenance and no-Ads/no-Billing policy checks.
  • CI37645292626 passed for ae3a7da.
  • Huawei Android10 isolated QA uses actual production composables + SettingsStore. Verified cold Settings startup, separate Ocean-light/Forest-dark themes, Dark mode, invalid/valid custom colors, font/text persistence after restart, corners, pure-black dark mode, reset, both rejected sliders, and late settings synchronization before a font change.
  • Save both label and Both callback verified; isolated label test does not assert new MediaStore writes.
  • Material You remains SDK12+ guarded; real wallpaper-color execution was not tested on the Android10 device.
  • QA app removed; production apps/data and global settings unchanged.

@Majkey25 Majkey25 changed the title fix: shorten combined save label feat: add Appearance settings and Save both Oct 7, 2026
@Majkey25
Majkey25 marked this pull request as ready for review October 7, 2026 16:03
@Majkey25
Majkey25 merged commit 0e54b44 into main Oct 7, 2026
1 check passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T16:04:41.338415Z ae3a7da Draft marked ready
🔒 Security Review ✅ Completed 2026-10-07T16:05:21.446758Z ae3a7da Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant