Repository navigation
Feat/143 datasource inspection - #189
Merged
Merged
Conversation
… all passed Updated Java targets, Docker runtime, CI, and documentation to Java 25. Security: Replaced Alpine runtime image with Ubuntu Noble variant; Docker diagnostic still reports one base-image vulnerability.
# Conflicts: # README.md # docs/architecture.md
|
Thank you for your contribution! We will review your request as soon as possible. Please review the code yourself using ponytail https://github.com/DietrichGebert/ponytail. |
VLSMB
reviewed
Nov 15, 2026
VLSMB
left a comment
Member
There was a problem hiding this comment.
首先感谢贡献。这里有几个小问题需要再改一下或者讨论一下。
另外在io.github.malonetalk.model.po.DatasourcePo上有一个字段testStatus是为本次功能准备的,可以在io.github.malonetalk.enums包内定义一个字符串枚举,一个测试成功一个测试失败,配置保存时直接保存测试成功的值(io.github.malonetalk.service.DatasourceServiceImpl#save,因为在保存配置前有调用测试方法),之后再点击测试时可以更新这个字段,并且这个字段可以在前端显示
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #143
Adds connection testing and table browsing to datasource management.
Validation:
Not included:
Screen.Recording.2026-11-14.at.8.33.13.PM.mov
Update — review feedback:
getHikariConfig.DatasourceTableVotoPhysicalTableInfoVo.DatasourceTestStatuswithSUCCESSandFAILEDvalues.Screen.Recording.2026-11-15.at.7.58.54.PM.mov