Skip to content

Feat/143 datasource inspection - #189

Merged
VLSMB merged 8 commits into
MaloneTalk:mainfrom
Zhou-Kan:feat/143-datasource-inspection
Nov 16, 2026
Merged

VLSMB merged 8 commits into
MaloneTalk:mainfrom
Zhou-Kan:feat/143-datasource-inspection

Conversation

@Zhou-Kan

@Zhou-Kan Zhou-Kan commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Close #143

Adds connection testing and table browsing to datasource management.

  • Test saved datasource connections using a temporary JDBC pool that is closed after use.
  • Test new datasource configurations before saving and keep the form open if the connection fails.
  • Apply driver-level timeouts to connection tests and prevent PostgreSQL URL parameters from overriding them.
  • Browse physical tables and views, including names, types, and remarks, with loading, empty, and retry states.
    Validation:
  • mvn verify passed.
  • Added regression tests for stalled MySQL handshakes and PostgreSQL timeout overrides.
    Not included:
  • Persisting and displaying the last connection test status.
  • Testing unsaved changes in the edit form.
Screen.Recording.2026-11-14.at.8.33.13.PM.mov

Update — review feedback:

  • Move inspection timeouts into a per-database enum field.
  • Move inspection-specific pool configuration into getHikariConfig.
  • Rename DatasourceTableVo to PhysicalTableInfoVo.
  • Add DatasourceTestStatus with SUCCESS and FAILED values.
  • Validate connections in the backend before saving new configurations and persist a successful test status.
  • Update the persisted status after each connection test and display the latest result in the datasource list.
  • Clear the previous test status when editing a configuration.
Screen.Recording.2026-11-15.at.7.58.54.PM.mov

… all passed

Updated Java targets, Docker runtime, CI, and documentation to Java 25.
Security: Replaced Alpine runtime image with Ubuntu Noble variant; Docker diagnostic still reports one base-image vulnerability.
# Conflicts:
#	README.md
#	docs/architecture.md
@github-actions

Copy link
Copy Markdown

Thank you for your contribution! We will review your request as soon as possible. Please review the code yourself using ponytail https://github.com/DietrichGebert/ponytail.

@VLSMB VLSMB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

首先感谢贡献。这里有几个小问题需要再改一下或者讨论一下。

另外在io.github.malonetalk.model.po.DatasourcePo上有一个字段testStatus是为本次功能准备的,可以在io.github.malonetalk.enums包内定义一个字符串枚举,一个测试成功一个测试失败,配置保存时直接保存测试成功的值(io.github.malonetalk.service.DatasourceServiceImpl#save,因为在保存配置前有调用测试方法),之后再点击测试时可以更新这个字段,并且这个字段可以在前端显示

@Zhou-Kan Zhou-Kan closed this Nov 16, 2026
@Zhou-Kan Zhou-Kan reopened this Nov 16, 2026

@VLSMB VLSMB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution!

@VLSMB
VLSMB merged commit b936d53 into MaloneTalk:main Nov 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: 数据源管理页面添加测试连接和显示数据源所包含表的地方

2 participants