MDEV-39763 main.innodb_mrr_cpk fails under view protocol#5343
Open
grooverdan wants to merge 1 commit into
Open
MDEV-39763 main.innodb_mrr_cpk fails under view protocol#5343grooverdan wants to merge 1 commit into
grooverdan wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables the view protocol around a specific test block in mysql-test/main/innodb_mrr_cpk.test to prevent overlapping fieldnames from causing ER_DUP_FIELDNAME errors, which was impacting the EXPLAIN output when index condition pushdown is disabled. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The rows returned by this under view protocol where inconsistent. Under view protocol the create view in a different thread was providing statistics that ended up in the result. To normalize the output: * Disable innodb_stats_auto_recalc for duration of test. * Use analyze with persistent stats on the tables. Despite the CREATE VIEW being executed under view protocol, it aways failed as most cases in the test had t1 and t2 with the same columns and a SELECT * FROM t1,t2 form of query resulting in duplicate field names. To make the results more consistent with a view protcol returning the first column generated the same query plan. Thanks Rex Johnston for guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 12.3, this test has been failing under view protocol.
During the creation of the view for ICP=off, the ha_innobase::info_low gains a measurement of the nuber of rows. This measurement showed up in the explain output as a difference in row number despite no query plan change.
The majority of the SELECT statements in this test are of the form:
SELECT * FROM t1,t2 ..
where t1 and t2 have a significant overlap in column names. The creation of the view ultimately fails with ER_DUP_FIELDNAME. No view protocol is exercised for the majority of the tests.
As such, disabled the view protocol for the portion of tests that resulted in ER_DUP_FIELDNAME when a view of them is created.