Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The denial test uses the third-button response even though denial is the second alert button.
1 open finding
What changed in this PR
Improves the credential-access alert to present permission requests more clearly.
Changes:
- Uses an informational style, app icon, clearer message, and explicit actions.
- Adds Simplified and Traditional Chinese translations.
- Expands alert presentation tests.
| File | Description |
|---|---|
EditorViewController+Delegate.swift |
Updates alert styling and actions. |
AppResources.swift |
Defines revised localized strings. |
Localizable.xcstrings |
Adds corresponding translations. |
EditorDocumentTests.swift |
Tests the updated alert presentation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See MarkEdit-app/extensions#54 (comment)