Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused cleanup preserves activation behavior and includes regression coverage, with no blocking issues identified.
0 open findings
What changed in this PR
Releases the Quick Search session after successful activation, including when focus transfer has already hidden the palette.
Changes:
- Explicitly cancels the session before notifying successful activation.
- Adds a regression test verifying session release after focus loss.
| File | Description |
|---|---|
| MarkEditMac/Modules/Tests/QuickSearchTests.swift | Tests session release and successful activation after focus loss. |
| MarkEditMac/Modules/Sources/QuickSearchUI/QuickSearchController.swift | Clears session state after successful activation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.