Skip to content

Respect optional settings.json in shared container - #1826

Merged
cyanzhong merged 1 commit into
mainfrom
develop
Oct 17, 2026
Merged

cyanzhong merged 1 commit into
mainfrom
develop

Conversation

@cyanzhong

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

HTML-sensitive settings strings can break inline-script parsing and prevent Quick Look initialization.

1 open issue
What changed in this PR

Allows shared-container consumers, including Quick Look, to load optional Shared/settings.json.

Changes:

  • Reads and validates settings, falling back to an empty object when unavailable or invalid.
  • Adds tests for missing, invalid, unreadable, updated, and string-valued settings.
File Description
MarkEditCore/​Tests/​EditorIndexHtmlTests.swift Tests settings loading and value preservation.
MarkEditCore/​Sources/​EditorIndexHtml.swift Loads shared settings and logs failures.

Review effort: Balanced

Comment thread MarkEditCore/Sources/EditorIndexHtml.swift
@cyanzhong
cyanzhong merged commit 4f5daf6 into main Oct 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants