Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues, and updated tests cover the primary switching behavior; AppKit tests were not executed.
No open issues 🎉
What changed in this PR
Improves Quick Search mode switching with keyboard shortcuts and filter-specific placeholders.
Changes:
- Adds Command–0 through Command–5 shortcuts and reorders filters.
- Updates placeholders to describe the selected search mode, including localized text.
- Expands tests for shortcuts, placeholders, and retained filter state.
| File | Description |
|---|---|
| MarkEditMac/Sources/Main/AppResources.swift | Moves Quick Search strings beside their integration code. |
| MarkEditMac/Sources/Main/Application/AppDelegate+QuickSearch.swift | Supplies localized, filter-specific placeholders. |
| MarkEditMac/Resources/Localizable.xcstrings | Adds translations for search targets and placeholder formatting. |
| MarkEditMac/Modules/Tests/QuickSearchTests.swift | Adapts tests to the placeholder closure. |
| MarkEditMac/Modules/Tests/QuickSearchMenuTests.swift | Updates controller initialization. |
| MarkEditMac/Modules/Tests/QuickSearchFilterTests.swift | Tests shortcuts, placeholders, ordering, and reopening. |
| MarkEditMac/Modules/Sources/QuickSearchUI/QuickSearchWindow.swift | Routes filter shortcuts and placeholder updates. |
| MarkEditMac/Modules/Sources/QuickSearchUI/QuickSearchView.swift | Handles guarded shortcut dispatch and placeholder changes. |
| MarkEditMac/Modules/Sources/QuickSearchUI/QuickSearchFilterLabels.swift | Places document filters before file filters. |
| MarkEditMac/Modules/Sources/QuickSearchUI/QuickSearchController.swift | Assigns shortcuts and refreshes placeholders on mode changes. |
| MarkEditMac/Modules/Sources/QuickSearchCore/QuickSearchFilter.swift | Exposes the filter type for placeholder customization. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.