Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused layout change preserves styling and selection behavior, with no identified blocking issues.
No open issues 🎉
What changed in this PR
Improves optical alignment of Quick Search result icons while preserving their background styling.
Changes:
- Separates symbol glyphs from fixed-size backgrounds, allowing native symbol alignment.
- Updates layout assertions to check the background view.
| File | Description |
|---|---|
| MarkEditMac/Modules/Tests/QuickSearchWindowTests.swift | Checks background dimensions and corner styling. |
| MarkEditMac/Modules/Sources/QuickSearchUI/QuickSearchResultsView.swift | Separates glyph and background views and removes the alignment override. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.