Repository navigation
fix: pre-release review fixes for 2.5.0 - #380
Merged
Merged
Conversation
- custom graphs: count test attempts from the stored rebot --merge JSON
history; it was read as a number, so the "Retried tests per run" preset
never showed data
- custom graphs: the regex guard also refuses repeated groups with
alternatives, counted repeats and nested repeats ((a|a)*, (a+){20},
(.*a){12}, ((a+))+), which froze the dashboard for 13-47 s
- notes: drop the unused confirm import and dead code left from the
removed delete confirmation
- robot: wait for the open animation of a modal before filling and
confirming it (Bootstrap ignores hide() during the fade), fixes the
flaky "Merge Two Filter Profiles Into A New One" and the same race in
the stat widget, link widget, custom section and custom graph keywords
- changelog: note that uploads no longer touch the server working folder
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found while reviewing and testing everything since v2.4.1 before the 2.5.0 release.
Fixes
engine.jsreadtest.attemptsas a number, but the database stores therebot --mergehistory as a JSON list, so every test counted as 1 attempt. It now counts the list entries. The unit test fixture used"2", which is not the real format; it now uses the stored JSON format.(a+)+. On a 29-character test name,(a|a)*$took 47 s,(a+){20}$30 s and(.*a){12}$13 s, and a shared or forced JSON config would freeze the dashboard for every viewer. A small scanner now refuses any repeated group that contains a quantifier or an alternative, at any depth. New tests cover both blocked and allowed patterns;docs/custom-graphs.mdis updated.confirm_actionimport and dead code left over from the dropped delete confirmation (no behaviour change).Merge Two Filter Profiles Into A New One. Bootstrap ignoreshide()while a modal is still fading in, and the test clicked Save about 240–300 ms after opening, inside the 300 ms fade. A newWait For Modal Openedkeyword waits for the fade-in to finish. The stat widget, link widget, custom section and custom graph keywords had the same timing problem and use it too.[Unreleased]entry says that uploads no longer touch the server's working folder, so a log next to the server is only linked when it is uploaded (uploadlog=true,/add-log-file) or given with--logurl.Local verification
🤖 Generated with Claude Code