Repository navigation
fix(cpu): give each processor the slot its own APIC ID register names - #803
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cpu_topology_get_logical_slotgives each processor the slot its own APIC ID register names. It read one identifier recorded on the bootstrap processor, so every processor got slot 0 and the heap's first domain.apic_is_running), only the bootstrap processor runs, and it keeps the recorded identifier.CPU_TOPOLOGY_NO_SLOTinstead of being registered.cpu_topology_get_local_apic_idand its setter now say the bootstrap processor's.Two heap tests relied on the bug: each application processor's start-up blocks landed in domain 0, leaving domain 1 empty. They now empty domain 1 first.
Verify
the_running_processor_keeps_the_slot_of_its_own_registerandevery_processor_finds_its_own_slot.-cpu max863/0,-smp 4861/0, pc 855/0,-smp 1856/0. Satellite: q35 711/0, pc-cpu max706/0.apic_is_runningalways true survives: on QEMU the early read names no slot, which callers treat as slot 0.Not in it
Closes #792