Repository navigation
fix(ioapic): leave out the inputs an I/O APIC declares past entry 0x77, and count them - #804
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An I/O APIC's version register declares up to 256 inputs, but its 8-bit register index reaches entry 0x77 at most (82093AA datasheet, §3.1.1 and §3.2.4). Since #799 an entry past 0x77 gets no register. The routing scaffold now also keeps only the first 120 inputs of each unit, so a Global System Interrupt past them belongs to no unit and no route reaches it.
The inputs left out are counted once, when the scaffold runs, rather than per route asked:
ioapic_inputs_unreachablein the[LPLTLM] machinerecord.Verify
an_io_apic_keeps_the_inputs_its_index_reacheswas red on a stub that kept every declared input: 121 and 256 stayed whole.-cpu max863/0, pc 855/0. Satellite: q35 711/0. Each record saysioapic_inputs_unreachable=0.Not in it
Closes #572