Skip to content

<fix>[db]: ZSTAC-85010 add CBT temp volume schema#4564

Open
ZStack-Robot wants to merge 2 commits into
5.4.12from
sync/yingzhe.hu/fix/ZSTAC-85010-5.4.12@@2
Open

<fix>[db]: ZSTAC-85010 add CBT temp volume schema#4564
ZStack-Robot wants to merge 2 commits into
5.4.12from
sync/yingzhe.hu/fix/ZSTAC-85010-5.4.12@@2

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Summary

Add the database schema for CbtTaskTemporaryVolumeVO in the 5.4.12 upgrade SQL. This table is used by the companion premium CBT fix to keep scratch volumes out of CbtTaskResourceRefVO.

Changes

  • Add CbtTaskTemporaryVolumeVO to conf/db/upgrade/V5.4.12__schema.sql.
  • Define (taskUuid, sourceVolumeUuid) unique constraint to match the premium VO.
  • Add cascade foreign keys to CbtTaskVO and VolumeEO.

Testing

  • git diff --check upstream/5.4.12..HEAD

Companion premium MR will use the same source branch name: fix/ZSTAC-85010-5.4.12@@2.

Supersedes premium-only MR: http://dev.zstack.io:9080/zstackio/premium/-/merge_requests/14737

Resolves: ZSTAC-85010

sync from gitlab !10532

Create CbtTaskTemporaryVolumeVO in the 5.4.12 schema upgrade.

Ensure the premium CBT temp-volume mapping table exists before

startup legacy data migration runs.

Resolves: ZSTAC-85010

Change-Id: I38a98c47ee71c5ddbf404779544696b4bac50467
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 07b91a30-0357-4164-9ead-f09c2bfb4553

📥 Commits

Reviewing files that changed from the base of the PR and between e1f99b2 and a507880.

📒 Files selected for processing (1)
  • conf/db/upgrade/V5.4.12__schema.sql

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/yingzhe.hu/fix/ZSTAC-85010-5.4.12@@2

Comment @coderabbitai help to get the list of available commands.

Migrate legacy CBT scratch volume refs into CbtTaskTemporaryVolumeVO during the 5.4.12 schema upgrade.

Also restore real source volume refs and delete old scratch-volume refs from CbtTaskResourceRefVO so business code no longer needs runtime legacy fallback.

Test: git diff --check upstream/5.4.12..HEAD -- conf/db/upgrade/V5.4.12__schema.sql

Resolves: ZSTAC-85010

Change-Id: Ib38c88c91c3a140cc1e684baa9f25d6f1b4047d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants