<fix>[core]: cap client keep-alive below agent socket timeout#4567
<fix>[core]: cap client keep-alive below agent socket timeout#4567ZStack-Robot wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
MN's async RESTFacade HTTP client (Apache HttpAsyncClient) never set a keep-alive strategy, so idle connections in the pool live forever: the default strategy returns -1 when the agent sends no Keep-Alive header. The agent cherrypy HTTP server closes idle keep-alive connections at its socket_timeout (10s default, 15s after the agent-side fix). When the pool reuses a connection the agent has already closed, the reused request hits a RST and surfaces as "Connection reset by peer" wrapped in error 1015 "Cannot make a HTTP request", intermittently disconnecting hosts. Cap the client keep-alive duration via a new global property RESTFacade.keepAliveTimeMillis (default 5000ms, below the agent socket_timeout) so the client always recycles an idle connection before the agent closes it. GlobalPropertyImpact Resolves: ZSV-12612 This commit is cherry-picked from ZSTAC-86545 (commit: abe313c) Change-Id: I70677a706d64637970766a64766d78726478776a
8ccfe18 to
6dd5bf6
Compare
MN's async RESTFacade HTTP client (Apache HttpAsyncClient) never set a
keep-alive strategy, so idle connections in the pool live forever: the
default strategy returns -1 when the agent sends no Keep-Alive header.
The agent cherrypy HTTP server closes idle keep-alive connections at its
socket_timeout (10s default, 15s after the agent-side fix). When the pool
reuses a connection the agent has already closed, the reused request hits
a RST and surfaces as "Connection reset by peer" wrapped in error 1015
"Cannot make a HTTP request", intermittently disconnecting hosts.
Cap the client keep-alive duration via a new global property
RESTFacade.keepAliveTimeMillis (default 5000ms, below the agent
socket_timeout) so the client always recycles an idle connection before
the agent closes it.
GlobalPropertyImpact
Resolves: ZSV-12612
This commit is cherry-picked from ZSTAC-86545
(commit: abe313c)
Change-Id: I70677a706d64637970766a64766d78726478776a
sync from gitlab !10535