Skip to content

<fix>[core]: cap client keep-alive below agent socket timeout#4567

Open
ZStack-Robot wants to merge 1 commit into
zsv_5.1.0from
sync/wenhao.zhang/zsv-2
Open

<fix>[core]: cap client keep-alive below agent socket timeout#4567
ZStack-Robot wants to merge 1 commit into
zsv_5.1.0from
sync/wenhao.zhang/zsv-2

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

MN's async RESTFacade HTTP client (Apache HttpAsyncClient) never set a
keep-alive strategy, so idle connections in the pool live forever: the
default strategy returns -1 when the agent sends no Keep-Alive header.
The agent cherrypy HTTP server closes idle keep-alive connections at its
socket_timeout (10s default, 15s after the agent-side fix). When the pool
reuses a connection the agent has already closed, the reused request hits
a RST and surfaces as "Connection reset by peer" wrapped in error 1015
"Cannot make a HTTP request", intermittently disconnecting hosts.

Cap the client keep-alive duration via a new global property
RESTFacade.keepAliveTimeMillis (default 5000ms, below the agent
socket_timeout) so the client always recycles an idle connection before
the agent closes it.

GlobalPropertyImpact

Resolves: ZSV-12612

This commit is cherry-picked from ZSTAC-86545
(commit: abe313c)

Change-Id: I70677a706d64637970766a64766d78726478776a

sync from gitlab !10535

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 33 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 674c6e61-959c-4a0f-80d1-8a1f50514622

📥 Commits

Reviewing files that changed from the base of the PR and between 49a2020 and 6dd5bf6.

📒 Files selected for processing (3)
  • core/src/main/java/org/zstack/core/CoreGlobalProperty.java
  • core/src/main/java/org/zstack/core/rest/RESTFacadeImpl.java
  • test/src/test/groovy/org/zstack/test/integration/core/rest/RestFacadeKeepAliveCase.groovy
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/wenhao.zhang/zsv-2

Comment @coderabbitai help to get the list of available commands.

MN's async RESTFacade HTTP client (Apache HttpAsyncClient) never set a
keep-alive strategy, so idle connections in the pool live forever: the
default strategy returns -1 when the agent sends no Keep-Alive header.
The agent cherrypy HTTP server closes idle keep-alive connections at its
socket_timeout (10s default, 15s after the agent-side fix). When the pool
reuses a connection the agent has already closed, the reused request hits
a RST and surfaces as "Connection reset by peer" wrapped in error 1015
"Cannot make a HTTP request", intermittently disconnecting hosts.

Cap the client keep-alive duration via a new global property
RESTFacade.keepAliveTimeMillis (default 5000ms, below the agent
socket_timeout) so the client always recycles an idle connection before
the agent closes it.

GlobalPropertyImpact

Resolves: ZSV-12612

This commit is cherry-picked from ZSTAC-86545
(commit: abe313c)

Change-Id: I70677a706d64637970766a64766d78726478776a
@MatheMatrix MatheMatrix force-pushed the sync/wenhao.zhang/zsv-2 branch from 8ccfe18 to 6dd5bf6 Compare July 14, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant