Add Russian translations for the desktop entries and AppStream metadata - #497
Closed
wehrwolfmann wants to merge 1 commit into
Closed
Add Russian translations for the desktop entries and AppStream metadata#497wehrwolfmann wants to merge 1 commit into
wehrwolfmann wants to merge 1 commit into
Conversation
Matoking
reviewed
Aug 10, 2026
wehrwolfmann
force-pushed
the
russian-metadata
branch
from
August 10, 2026 19:17
ee518f7 to
377b8e9
Compare
Owner
|
Thanks, I've merged the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protontricks has no translations at the moment, so a Russian user sees the English name and description in the application menu and in the software centre.
This adds Russian to the places that are translated declaratively and need no new build machinery:
protontricks.desktop:GenericName[ru],Comment[ru],Keywords[ru]protontricks-launch.desktop:Name[ru],Comment[ru]xml:lang="ru"for the summary, the description and the screenshot captionTwo English keys are added along the way, since a localised key without its untranslated counterpart looks odd:
GenericNamefor the main entry, andCommentfor the launcher entry, which had no description at all.Checked with
desktop-file-validate(both files pass) andappstreamcli validate --pedantic(passes; the only remaining hint is the pre-existing uppercase letter in the component ID). Verified withGLib.KeyFile.get_locale_stringthat both entries resolve to the Russian strings underru_RU.UTF-8and are unchanged under other locales.No gettext machinery is proposed here. Most of the remaining user-visible text is command-line diagnostics that people paste into bug reports, and wiring up message catalogues for it would be a much bigger change than it is worth. If you would like proper i18n later, the dialog strings in
gui.pyare the part that would actually benefit.