Repository navigation
fix(ttl): extend instance storage TTL in keep_alive across all contracts (#566) - #764
Open
huangji6693-max wants to merge 1 commit into
Open
huangji6693-max wants to merge 1 commit into
huangji6693-max wants to merge 1 commit into
Conversation
|
@huangji6693-max is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #566
Problem
keep_aliveinmergefi-escrow,mergefi-milestones, andmergefi-maintenance-poolextended the target persistent record and its sub-records, but never calledextend_instance_ttl(&env). Because instance storage holdsAdmin,Oracle,Treasury,FeeBps,Paused, andMaxSponsors, a contract kept alive solely viakeep_aliveduring a quiet period would allow its instance storage to archive.Solution
extend_instance_ttl(&env)insidekeep_aliveinescrow,milestones, andmaintenance-pool.test_keep_alive_refreshes_instance_ttlin all three contracts advancing the ledger sequence pastINSTANCE_TTL_THRESHOLD(50_000ledgers remaining <100_000threshold) while calling onlykeep_alive, asserting instance TTL is restored to500_000ledgers.Verification
CARGO_BUILD_JOBS=2 cargo test -p mergefi-escrow -- test_keep_alive_refreshes_instance_ttl(passed)CARGO_BUILD_JOBS=2 cargo test -p mergefi-milestones -- test_keep_alive_refreshes_instance_ttl(passed)CARGO_BUILD_JOBS=2 cargo test -p mergefi-maintenance-pool -- test_keep_alive_refreshes_instance_ttl(passed)CARGO_BUILD_JOBS=2 cargo clippy --workspace --lib --locked -- -D warnings(0 warnings)