Repository navigation
Fix reactions targeting stale Linq messages - #167
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linq reactions targeted the message cached in the thread snapshot at session creation. A later "Like this message" request could therefore react to an older message. Resolve the target from the current incoming message's authenticated context, require its conversation to match the active thread, and reject missing message IDs.
Validation:
pnpm exec vitest run tests/agent/channels/linq-message-delivery.test.ts— 42 tests passed. Five new regressions failed before the fix and cover stale snapshots for add/remove, absent snapshots, missing incoming IDs, and conversation mismatches.pnpm check— all six tasks passed; 876 tests across 95 files. An initial database migration test timed out while the build ran concurrently; the complete rerun passed.pnpm build— passed.A direct retry through Linq's native reaction API was received by the user. The updated handler has not yet been verified in production.