Repository navigation
fix(gmail): retrieve externally stored message text bodies - #177
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gmail can return a text message body through
body.attachmentIdwith absent or empty inlinedata. Thread reading previously returned an empty body for these messages. Retrieve external plain text and HTML bodies through the generated attachments API, then apply the existing decoding, HTML cleanup and credential redaction. Named file attachments remain attachment metadata.Six regression/control cases exercise the real tool, OAuth client, generated Gmail SDK and HTTP transport against a local fixture with a synthetic token. Four cases fail before the fix and all six pass after; inline, empty and nested bodies remain readable, and retrieval errors surface. All 14 focused Google Workspace tests, full lint and TypeScript checks pass. Full
pnpm checkpasses (96 files, 882 tests), and the exact source passes the unmodified author-fork Checks workflow, including runtime evaluation. Localpnpm buildpasses. The local build reported a Turbo cache disk-space warning at completion; completed output cleanup restored the dependency paths without altering source or installed packages. Live Gmail accounts were not accessed.The unchanged Checks workflow completed successfully on exact signed head
acdf235dc1cd3c7e83588c9a5519efe9a4725d81, including frozen installation, all six check tasks and the complete two-scenario / 13-gate runtime command with cleanup. The merge checkout tree matches the reviewed source. The local build exited 0; its Turbo cache ENOSPC warning and dependency restoration after completed build-output cleanup are retained. Local Docker cleanup remains blocked; it is not counted as passing. No workflow, dependency or runtime fixture changes.AI assistance was used for investigation, implementation, tests and review under the submitting account. Signed DCO commit included.