Repository navigation
fix(memory): search original workstream text values - #178
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Find workstream text as it was saved, including quoted report titles, Windows source paths and multiline notes.
workstreams__findcurrently searches a JSON serialization of the stored content. JSON adds escape characters to quotes, backslashes and newlines, so querying the original saved text returns no record. The ID search and literal SQL wildcard escaping already work.Search the original string values with PostgreSQL JSON path extraction before applying the existing case-insensitive literal
ILIKEpattern. This includes nested source references and observations. Keep filtering inside the database query so the existing 20-record page, offset and ordering still apply to matching records.Native reproduction and controls
The regression invokes the actual memory provider's save and find tools using an owned interactive memory context, real PGlite/Drizzle and committed migrations. Only the database driver getter is replaced; SQL results and ordering are real. Ordinary inputs are a quoted report title, a Windows document source path and two-line notes, accepted by the shipped save schema.
%/_control pass.Required verification passed on this exact signed source:
pnpm build/ Next build with TypeScript and all 14 generated static pages, cache miss, successful cleanup. Public synthetic environment fixtures only; no deployment or live services.Full build/check/runtime were run on hosted Linux because local disk exhaustion and local Docker cleanup prevented reliable local full gates. Upstream CI may still require maintainer authorization and is not claimed green.
Scope and overlap
One SQL predicate change and five regression cases in the existing owning test file. No schema, migration, dependency, workflow or production test seam changes. Searching text values replaces searching JSON encoding and structural key names; ID matching remains separate.
All 19 current open PR full bodies and file lists were screened: none touch workstream files. The most recent 100 closed PR bodies identify merged #136 as the original workstream feature; it introduced the current serialized-JSON search and does not contain this repair. This is not a live model, HTTP authentication, deployed PostgreSQL or UI test.
AI assistance was used for investigation, implementation, tests and review under the submitting account. Signed DCO commit included.