Repository navigation
fix(chat): preserve drafts after failed composer submissions - #180
Open
rudycelekli wants to merge 2 commits into
Open
rudycelekli wants to merge 2 commits into
rudycelekli wants to merge 2 commits into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shipped chat composer resets its uncontrolled form before sending a message. When the actual Eve client rejects the send, the submitted text has already disappeared, preventing a straightforward retry.
Change
Restore the captured text on synchronous or asynchronous submission failure when the current textarea is still empty. Keep immediate reset on submission, successful-send clearing and a newer nonempty draft. Emit an input event so the compact composer measures restored text.
Evidence
d8e12f11f134f5f037da6a265ce13729a7952631: frozen installation, fullpnpm check(6 tasks; 95 files / 880 tests), andpnpm test:runtime(2 evaluations / 13 gates) passed, including post-job cleanup. GitHub checked out merge commitba847b3a744afbb811ed39084fb83f8c5d27fed0, whose tree exactly matches the source head.pnpm build(1 task). This supplemental verification workflow is outside the proposed source patch and uses fresh public installation fixtures.The original hosted Checks and supplemental build on
1032f6afailed on a regression-test callback type (TS2345); runtime was skipped in those failed Checks. A normal signed followup explicitly declares the callback argument. Production source is byte-identical, and the final same-byte fixture retains the before/after result above. Local heavy builds were held because the shared host repeatedly ran out of disk space; the required commands completed successfully in the hosted verification above.Recovery applies to the current empty uncontrolled textarea. It preserves a later nonempty draft; this does not claim recovery for provider-controlled input. No agent, database, dependency or upstream workflow changes. Both commits are signed and carry DCO signoffs.
AI assistance was used for investigation, implementation, tests and source review under the submitting account.
Upstream workflow authorization is separate; no pending upstream check is claimed green.