Repository navigation
fix(chat): preserve delivered plain text verbatim - #181
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shipped send_message tool promises plain text delivered exactly as written. The default iMessage transcript sends its text through a Markdown renderer: literal stars and backticks disappear, numbered notes become a list, and an old hard-break conversion changes trailing spaces.
Change
Render user-visible text as plain text with its original whitespace. Keep bare HTTP(S) URL segments in the existing MessageResponse renderer, including its external-link confirmation. Remove the producer's Markdown-only newline conversion. Full trace retains intentional Markdown rendering; attachment and input-request branches retain their existing behavior.
Evidence
367ef598e5e1de557f68fdb285aa1f21b0bbf68a: frozen installation, fullpnpm check(6 tasks; 95 files / 885 tests), and completepnpm test:runtime(2 evaluations / 13 gates), including post-job cleanup. Its actual merge checkout05f17388662056e0959ee8790dc82e461946d239has the identical source tree.pnpm build(1 task; 14 generated static pages). It uses fresh public installation fixtures and an owned helper workflow outside this patch. No upstream workflow or dependency change.Overlap and limits
Fresh overlap records include all 23 open PR bodies and the full #169/#170 diffs. #169 rewrites the transcript projection, removes the separate delivery map and retains the hard-break conversion and unchanged parts Markdown renderer; it does not correct this plain-text formatting behavior. Its producer/test changes will require adapting this small newline-conversion removal if it merges first. #170 adds a messaging provider and retains the same plain-text tool contract.
No live model, provider account, channel network delivery or deployed application claim. Local heavy builds were held by shared-host disk exhaustion; the exact hosted required commands above passed. Upstream workflow authorization is separate and no pending upstream check is claimed green.
AI assistance was used for investigation, implementation, tests and source review under the submitting account. Signed DCO commit included.