Forward offline wardrive batches to Custom API after upload - #28
Merged
MrAlders0n merged 3 commits intoAug 19, 2026
Merged
Conversation
After a successful offline batch upload to MeshMapper, mirror the online queue behavior by forwarding the same pings to the configured Custom API endpoint. Adds detailed [CUSTOM API] / [OFFLINE] debug logging for tracing. Co-authored-by: Cursor <cursoragent@cursor.com>
Keeps upstream PR limited to offline Custom API forward changes. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Reviewed — the forward logic is solid and mirrors the online queue path exactly (verified the partial-upload retry can't double-forward, and the contact format matches the online I pushed one small follow-up commit (c6f0fc3) with three log-hygiene tweaks rather than round-tripping review comments:
Will merge once CI is happy. |
…ntics Review follow-ups on the offline Custom API forward: - Log the endpoint host instead of the full URL — debug log files are uploaded with bug reports and custom endpoint URLs may embed tokens. - Skip the "Forward requested/skipped" logging entirely when the Custom API feature is disabled (no per-flush noise for users who never enabled it). - Document that offline batches are stamped with the upload-location zone, not the record-location zone.
MrAlders0n
force-pushed
the
feature/offline-custom-api-forward
branch
from
August 19, 2026 12:36
55fac41 to
c6f0fc3
Compare
Contributor
Author
|
Thanks for the review and the follow-up commit — the host-only logging, quiet disabled path, and iata semantics note all make sense. Appreciate the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After a successful offline session upload to meshmapper.net, forward the same ping batch to the configured Custom API endpoint — mirroring the existing online queue behavior (
api_queue_servicealready callsforwardPings()on success).app_state_provider.dart: call_forwardOfflineBatchToCustomApi()after each successful offline batchcustom_api_service.dart: optionalsource(online/offline), contact/iata overrides, clearer[CUSTOM API]debug logsMotivation
Online uploads already fire-and-forget to Custom API. Offline uploads (
_uploadOfflineSessionIsolated) previously only POSTed to meshmapper.net — third-party endpoints (e.g. wardrive bridges) never received offline data.Test plan
Fork test build: DataArchitectPro/MeshMapper_Flutter_App v1.0.0-offline-custom-api