feat(stellar-wallet-snap): Implement keyring API exportAccount - #215
Closed
stanleyyconsensys wants to merge 12 commits into
Closed
feat(stellar-wallet-snap): Implement keyring API exportAccount#215stanleyyconsensys wants to merge 12 commits into
exportAccount#215stanleyyconsensys wants to merge 12 commits into
Conversation
| this.#logger.debug('Keyring request handled', { | ||
| origin, | ||
| method: request.method, | ||
| result: keyringRequestResult, |
Contributor
Author
There was a problem hiding this comment.
remove it for prevent logging the PK
stanleyyconsensys
changed the title
exportAccount
Contributor
Author
|
@copilot review |
Reviewed. I verified the keyring handler no longer logs keyring results, so private key material from |
|
|
||
| ### Added | ||
|
|
||
| - Add `exportAccount` keyring method for base32 Stellar secret-seed export ([#187](https://github.com/MetaMask/internal-snaps/pull/187)) |
Contributor
Author
There was a problem hiding this comment.
will update the PR number
hmalik88
reviewed
Aug 31, 2026
| /** | ||
| * Validation struct for a Stellar secret seed (`S…` strkey / base32). | ||
| */ | ||
| export const StellarSecretKeyStruct = refine( |
Contributor
There was a problem hiding this comment.
Can you use the sensitive struct that we have here?
…pi` to `24.1.0` + `snaps-execution-environments` to `11.3.0` + `metamask/snaps-jest` to `10.2.1` + `metamask/keyring-snap-sdk` to `10.0.0` (#214) ## Explanation ### This PR bumps - snap-sdk from 11.2.0 to 12.0.1 - it is a breaking change from snap-sdk, as it requires kerying api 24.1.0+ - it will start to pass the `Origin metadata` to keyring api submit request, but none of our validation is blocking it, so it is safe to bump - snap-utils from 12.4.0 to 12.6.0 - kerying api from 23.7.0 to 24.1.0 - it is a breaking change from keyring api, as it drop node version support 20 and 18 - Client already support that version, safe to bump - snaps-execution-environments from 11.2.0 to 11.3.0 - metamask/snaps-jest 10.2.0 to 10.2.1 - metamask/keyring-snap-sdk 9.2.1 to 10.0.0 ### With those bumps, they add - support PrivateKeyEncoding with base32 (It will be used for Stellar Private Key Export) - support for the optional originMetadata property to all handlers that also support origin ### Test bump PR on client MetaMask/metamask-extension#45822 <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
An error occurred while trying to automatically change base from
bump/snap-sdk
to
main
September 1, 2026 08:37
An error occurred while trying to automatically change base from
bump/snap-sdk
to
main
September 1, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR Implement keyring API exportAccount
References
Checklist