chore: enable Snap TypeScript checking

[ulissesferreira]

Explanation

The repository had TypeScript configuration files for the packages, but the package source was not being type-checked as part of the normal CI lint workflow. Snap builds were transpiled by mm-snap, so TypeScript diagnostics could be missed until later in development.

This pull request makes TypeScript checking an explicit CI requirement for all repository and workspace packages:

• Fixes existing TypeScript problems that are now visible
• Adds lint:tsc script
• Adds lint:tsc to the CI checks
• Standardizes Snap package's tsconfig.json files so they all match
• Root tsconfig files are now made with Snap packages as first class! The "normal" library package is the exception so it gets its own tsconfig overrides

References

None.

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

[ulissesferreira]

This package is the only exception so let's not have that root file

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	comment-json@​4.5.1 ⏵ 4.6.2	+1		+1

View full report

[taran-a]

@ulissesferreira, GG—nice work. I spotted one thing: you added a lot of explicit types across the files. For example, types used only for struct imports aren’t needed if references to the shared utility are removed.

It may be worth running the type check with only the tsconfig changes introduced in this PR. That should reduce the number of required explicit types and shrink the review surface.

[ulissesferreira]

@ulissesferreira, GG—nice work. I spotted one thing: you added a lot of explicit types across the files. For example, types used only for struct imports aren’t needed if references to the shared utility are removed.

It may be worth running the type check with only the tsconfig changes introduced in this PR. That should reduce the number of required explicit types and shrink the review surface.

Great catch! My patience was running thin, iterating on this again 🙏, we are close

[ulissesferreira]

Changed these to match the other Snaps

[stanleyyconsensys]

it looks like there are some rebase issue