Repository navigation
Conversation
Each time the `test` job in CI runs, we end up downloading browsers that the Playwright tests rely upon. This is wasteful and error-prone. Cache the browsers so that we no longer need to do this.
mcmire
force-pushed
the
cache-playwright-browsers
branch
from
November 3, 2026 23:16
0d91db8 to
a94148e
Compare
mcmire
enabled stacked auto-merge (squash)
November 3, 2026 23:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each time the
testjob in CI runs, we end up downloading browsers that the Playwright tests rely upon. This is wasteful and error-prone. Instead, download all browsers up front and cache them for future jobs.(Most of the code here was copied from the Extension: https://github.com/MetaMask/metamask-extension/blob/73f296fae151c8edf966290381a2324fa3cdd6c3/.github/actions/install-playwright-browsers/action.yml)