Repository navigation
fix(perps): finish recipe-cook tasks with criteria awaiting review - #208
Open
abretonc7s wants to merge 1 commit into
Open
abretonc7s wants to merge 1 commit into
abretonc7s wants to merge 1 commit into
Conversation
Criteria the harness records as awaiting-review go to the run gate, which reviews them after the worker completes. The skill told workers to hold the task pending for that review instead, so the worker never signalled complete and the run deadlocked.
abretonc7s
enabled auto-merge (squash)
November 2, 2026 09:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
perps/recipe-cooktold workers to hold the task pending when the harness recordsawaiting-reviewfor captured visual proof ("return that pending status … never complete the task"). That review is collected by the run gate, which only opens after the worker completes, so a worker following the skill never signalled complete and the run deadlocked at its nudge limit.The skill now says to finish with the terminal mark when the task checks permit it; criteria awaiting review go to the run gate with the completed task. It still forbids approving a criterion or weakening its proof kind. This matches the Farmslot task contract ("mark complete with them: the run gate presents them to an authorized person"). No other behaviour change.
Type of Change
Checklist
Testing
node .github/scripts/lint-skill-entry.mjs: the same result as the base branch (one existing error intypescript/tsc-blindspots, unrelated). Text-only change to two lines plus a CHANGELOG entry.