Repository navigation
docs(testing): update visual-testing skill for client-mcp-core 0.13.1 - #210
Open
cryptotavares wants to merge 2 commits into
Open
cryptotavares wants to merge 2 commits into
cryptotavares wants to merge 2 commits into
Conversation
This was referenced Nov 1, 2026
| | `mm get-contract-address` | Get deployed contract address | | ||
| | `mm list-contracts` | List all deployed contracts | | ||
|
|
||
| The knowledge store commands (`mm knowledge-search`, `mm knowledge-last`, `mm knowledge-sessions`, `mm knowledge-summarize`) and the `mm launch --goal` / `--flow-tags` flags were removed in `@metamask/client-mcp-core` 0.13.0. Session metadata is written to `test-artifacts/<sessionId>/session.json`. |
Contributor
There was a problem hiding this comment.
Is this reference to knowledge store necessary for agents running older versions? We anyway now return an error when trying to reference the knoweldge store.
pnarayanaswamy
previously approved these changes
Nov 2, 2026
cryptotavares
marked this pull request as ready for review
November 2, 2026 21:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the Mobile
testing/mobile-visual-testingskill for@metamask/client-mcp-core0.13.0 (release PR #80) and@metamask/device-mcp0.7.0. With 0.13.0, agents that follow the current skill fail on step 2:mm knowledge-searchnow returnsError: unknown command 'knowledge-search'.This is the Mobile counterpart of #210 (Extension
visual-testingskill).mm knowledge-*in the CLI reference, error recovery and verify loop;--goal/--flow-tagslaunch flagstest-artifacts/<sessionId>/session.jsonpath--observe none|diff|fullflag, per-category defaults (reads, discovery andcdpreturn none), stale refs after--observe none, only mutating/batch calls wait for animations, no app state in observations, flat mobile a11y tree without status/nav bars and dev overlayget-stateisLoaded,extensionId,source: "stub". NocurrentScreenand no wallet fields; identify the screen from test IDsclick --testid Doneinstead ofdismiss-keyboard;tap-coordinatesfor wallet home Buy / Swap / Send / Receive (missing from the iOS 18+axbridgetree). Android:press-button backto hide the keyboard. Both:wait-forafter a slow navigation, because the observation can still show the previous screen--pretty/MM_PRETTY;meta.timingon every response;node_modules/.bin/mmto skip Yarn startuprun-stepsincludeObservations;batchTimeoutMswithout limitsobserve(replacesincludeObservations);batchTimeoutMsrange 1000–30000 and the 30 s request limitautodescribed as the defaulthelper-firstis the default since device-mcp 0.6.0;auto/instrument/dumpsemantics and first-snapshot install time updatedFiles:
domains/testing/skills/mobile-visual-testing/repos/metamask-mobile.md: workflow (knowledge step removed, observation guidance), batching, gotchas, Android snapshot modesdomains/testing/skills/mobile-visual-testing/references/cli-reference.md: new Global Options section; knowledge commands and launch flags removed;get-state,run-stepsandcdpupdateddomains/testing/skills/mobile-visual-testing/references/error-recovery.md: knowledge step removed; new failure rowsCHANGELOG.md: Unreleased entryCompanion Mobile PR: MetaMask/metamask-mobile#38594
Type of Change
Checklist
Testing
client-mcp-corerelease/0.13.0(mm --help,MobilePlatformDriver.getAppState) and the installed@metamask/device-mcp0.7.0 README.launch,describe-screen,get-state({"isLoaded":true,"extensionId":"...","source":"stub"}),type(diff observation),get-text(no observation),click --observe none|full,run-stepswithobserveandbatchTimeoutMs,includeObservationsandbatchTimeoutMs > 30000rejected,--pretty,cdp/hermes-targetswith--metro-port,screenshot,list-testids,cleanup;knowledge-*rejected as unknown commands. Results are in chore(llm-workflow): upgrade to @metamask/client-mcp-core 0.13.0 and @metamask/device-mcp 0.7.0 metamask-mobile#38594.cdpisUnlocked()); nothing was sent or signed.mm cdpdoes not reuse the launch's--metro-port(it defaults to 8081). Pass--metro-porton eachcdp/hermes-targetscall.get-statenever returnscurrentScreen.axbridgetree.mm dismiss-keyboardfails (idb ui key RETURNrejected).--testidmatches a substring (device-mcpfuzzyMatch): on Android wallet home,account-pickertapsaccount-picker-avatarand opens the profile screen.yarn lintpasses andyarn testpasses (73/73).yarn audit:skillsreports 1 error, intypescript/tsc-blindspots(description length). The same error is onmain; this PR adds no new errors.Additional Context
Merge this together with MetaMask/metamask-extension#47526. Until then, agents in the Extension are on 0.12.0, which still has the knowledge commands.