fix(profile-editor): render data: and blob: avatar URLs - #1128
Merged
Conversation
…uting them through the file manager
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Avatars stored as inline
data:image/...;base64,...URIs don't render in the profile editor — the image is broken everywhere an avatar/banner appears (profile header, discover cards).resolveAssetUrl()inplatforms/profile-editor/client/src/lib/utils/file-manager.tstreated anything that isn't an http(s) URL as a legacy bare file-manager id, so a data URI was percent-encoded and pasted onto the file-manager base:which 404s. Inline data URIs are a first-class avatar format in the ecosystem — the Web3 Adapter's
__file()directive explicitly acceptsavatarUrlas a data URI — so profiles synced in from other platforms hit this.Fix
Pass through anything the browser can already render — http(s), protocol-relative,
data:andblob:— and only prefix the file-manager base for a bare legacy id.blob:is included so localURL.createObjectURLpreviews stay safe if they're ever routed through this helper.Verification
pnpm run checkinplatforms/profile-editor/client: 0 errors (11 pre-existing warnings, unchanged).