Repository navigation
Conversation
Some users view tests went through signup and account activation without mocking send_pushover, so every test run sent real notifications to my phone. Add an autouse block_pushover fixture in tests/conftest.py that patches send_pushover where it's imported (users.utils, users.views and the sync_opencollective_donors and notify_throttled_clients commands). Tests that check Pushover calls still apply their own patch, which takes precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users view tests went through signup and account activation without mocking send_pushover, so every test run sent real notifications to my phone.
Add an autouse block_pushover fixture in tests/conftest.py that patches send_pushover where it's imported (users.utils, users.views and the sync_opencollective_donors and notify_throttled_clients commands). Tests that check Pushover calls still apply their own patch, which takes precedence.